Skip to content

fix(lint): don't show docs URLs for plugins #28033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

bartlomieju
Copy link
Member

This commit removes the docs URL for diagnostics coming
from JS plugins. Before, we mistakenly printed
URLs pointing to docs.deno.com, even though they did not
exist.

An ability to actually specify a custom URL for plugin rules,
will be added in a follow up PR.

@bartlomieju
Copy link
Member Author

bartlomieju commented Feb 10, 2025

Waiting on denoland/deno_lint#1415

@bartlomieju bartlomieju enabled auto-merge (squash) February 10, 2025 16:19
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 7bd210f into denoland:main Feb 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants