refactor(tsc): remove TS program creation during snapshotting #27797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Jan 24, 2025
| @@ -277,6 +230,28 @@ mod ts { | |||
| ) | |||
| .unwrap(); | |||
|
|
|||
| // Leak to satisfy type-checker. It's okay since it's only run once for a build script. | |||
There was a problem hiding this comment.
I'll fix it up in a follow up
bartlomieju
added a commit
that referenced
this pull request
Jan 30, 2025
This commit refactors how a snapshot is created for the TypeScript
compiler.
Instead of having 4 ops, only a single op ("op_load") is left. This is
achieved by not creating a "ts.Program" during snapshotting, that during
benchmarking doesn't provide much benefit.
This greatly simplifies build script for the TS snapshot and opens up
way to simplify it even further in follow up PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors how a snapshot is created for the TypeScript compiler.
Instead of having 4 ops, only a single op ("op_load") is left. This is achieved
by not creating a "ts.Program" during snapshotting, that during benchmarking
doesn't provide much benefit.
This greatly simplifies build script for the TS snapshot and opens up way to simplify
it even further in follow up PRs.