Skip to content

feat: Deno.cwd() no longer requires --allow-read permission #27192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ext/fs/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ where
{
let fs = state.borrow::<FileSystemRc>();
let path = fs.cwd()?;
state
.borrow_mut::<P>()
.check_read_blind(&path, "CWD", "Deno.cwd()")?;
let path_str = path_into_string(path.into_os_string())?;
Ok(path_str)
}
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/compile_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -820,14 +820,14 @@ fn compile_npm_cowsay_main() {
#[test]
fn compile_npm_no_permissions() {
run_npm_bin_compile_test(RunNpmBinCompileOptions {
input_specifier: "npm:[email protected].0",
input_specifier: "npm:@denotest/[email protected].0",
copy_temp_dir: None,
compile_args: vec![],
compile_args: vec!["-o", "denotest"],
run_args: vec!["Hello"],
output_file: "npm/deno_run_cowsay_no_permissions.out",
output_file: "npm/compile_npm_no_permissions.out",
node_modules_local: false,
input_name: None,
expected_name: "cowsay",
expected_name: "denotest",
exit_code: 1,
});
}
Expand Down
8 changes: 5 additions & 3 deletions tests/integration/run_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -358,10 +358,12 @@ fn permissions_prompt_allow_all_2() {
console.write_line_raw("A");
console.expect("✅ Granted all sys access.");

let text = console.read_until("Allow? [y/n/A] (y = yes, allow; n = no, deny; A = allow all read permissions)");
// "read" permissions
console.expect(concat!(
"┏ ⚠️ Deno requests read access to <CWD>.\r\n",
"┠─ Requested by `Deno.cwd()` API.\r\n",
test_util::assertions::assert_wildcard_match(&text, concat!(
"\r\n",
"┏ ⚠️ Deno requests read access to \"[WILDCARD]/tests/testdata/\".\r\n",
"┠─ Requested by `Deno.lstatSync()` API.\r\n",
"┠─ To see a stack trace for this prompt, set the DENO_TRACE_PERMISSIONS environmental variable.\r\n",
"┠─ Learn more at: https://docs.deno.com/go/--allow-read\r\n",
"┠─ Run again with --allow-read to bypass this prompt.\r\n",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
console.log("Hello in CLI with permissions");
console.log("Reading DENO_HELLO env var...");
console.log(Deno.env.get("DENO_HELLO"));
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"name": "@denotest/cli-with-permissions",
"version": "1.0.0",
"bin": "./index.js"
}
5 changes: 5 additions & 0 deletions tests/testdata/npm/compile_npm_no_permissions.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Hello in CLI with permissions
Reading DENO_HELLO env var...
error: Uncaught (in promise) NotCapable: Requires env access to "DENO_HELLO", specify the required permissions during compilation using `deno compile --allow-env`
console.log(Deno.env.get("DENO_HELLO"));
[WILDCARD]
2 changes: 0 additions & 2 deletions tests/testdata/npm/deno_run_cowsay_no_permissions.out

This file was deleted.

10 changes: 0 additions & 10 deletions tests/unit/dir_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,6 @@ Deno.test({ permissions: { read: true, write: true } }, function dirCwdError() {
}
});

Deno.test({ permissions: { read: false } }, function dirCwdPermError() {
assertThrows(
() => {
Deno.cwd();
},
Deno.errors.NotCapable,
"Requires read access to <CWD>, run again with the --allow-read flag",
);
});

Deno.test(
{ permissions: { read: true, write: true } },
function dirChdirError() {
Expand Down
Loading