Skip to content

chore: force import assertion support #23855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024
+4 −1
Merged

chore: force import assertion support #23855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f534800
chore: force import assertion support
bartlomieju May 16, 2024
543e6ac
Merge branch 'main' into import_assertions
bartlomieju May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,10 @@ fn resolve_flags_and_init(
// TODO(petamoriken): Need to check TypeScript `assert` keywords in deno_ast
vec!["--no-harmony-import-assertions".to_string()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this flag is no longer needed.

Copy link
Member Author

@bartlomieju bartlomieju May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it for now as the TODOs here seem important. We might need to support import assertions in deno_ast for some more time.

} else {
vec![]
// If we're still in v1.X version we want to support import assertions.
// V8 12.6 unshipped the support by default, so force it by passing a
// flag.
vec!["--harmony-import-assertions".to_string()]
}
}
};
Expand Down