Skip to content

feat(ext/fetch): Request.bytes() and Response.bytes() #23823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 23, 2024
Merged

feat(ext/fetch): Request.bytes() and Response.bytes() #23823

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2b71f38
feat(ext/fetch): `Request.bytes()` and `Response.bytes()`
iuioiua May 15, 2024
af55afd
tweaks
iuioiua May 15, 2024
b12ebe6
x
iuioiua May 16, 2024
4547849
Merge branch 'main' into body-bytes
iuioiua May 16, 2024
ecf15b4
update
iuioiua May 16, 2024
be45fc0
work
iuioiua May 16, 2024
4255f12
fix
iuioiua May 17, 2024
c7ec29e
fix
iuioiua May 17, 2024
7906cd5
work
iuioiua May 17, 2024
702c20f
Merge branch 'main' into body-bytes
iuioiua May 22, 2024
56c1c81
x
iuioiua May 22, 2024
f9baefe
fix
iuioiua May 22, 2024
889c915
fix
iuioiua May 22, 2024
d82ff4c
fix
iuioiua May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/wpt/runner/expectation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7153,8 +7153,12 @@
"response": {
"json.any.html": true,
"json.any.worker.html": true,
"response-blob-realm.any.html": true,
"response-blob-realm.any.worker.html": true,
"response-blob-realm.any.html": [
"realm of the Uint8Array from Response bytes()"
],
"response-blob-realm.any.worker.html": [
"realm of the Uint8Array from Response bytes()"
],
Comment on lines +7156 to +7161
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look funky. What are these tests doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/web-platform-tests/wpt/blob/master/fetch/api/response/response-blob-realm.any.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine since we don't support iframe.

"response-init-001.any.html": true,
"response-init-001.any.worker.html": true,
"response-init-002.any.html": true,
Expand Down