feat(cli/test): deno test --clean
#23519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 24, 2024
|
This has the downside that you can not run multiple |
|
I think it's a fair trade-off, as long as the behaviour is clearly documented. Perhaps, if we receive too many complaints, which we may not, we can add a For context, I recently waited for ~5 minutes on my M2 MacBook to delete |
|
The point is, as is, this PR breaks existing workflows |
|
We could make this behaviour opt-in via |
|
I've changed my mind. I think this should just be opt-in for good. |
iuioiua
changed the title
deno test --clean
bartlomieju
reviewed
May 5, 2024
bartlomieju
approved these changes
May 23, 2024
|
Should this only work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of the call is ignored as it throws even when the directory does not exist.
Closes #23491