Skip to content

fix(test): allow explicit undefined for boolean test options #18786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix(test): allow explicit undefined for boolean test options #18786

merged 1 commit into from
Apr 21, 2023

Conversation

nayeemrmn
Copy link
Contributor

Fixes #18784.

bartlomieju
bartlomieju approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 065d877 into denoland:main Apr 21, 2023
@nayeemrmn nayeemrmn deleted the test-bool-options-explicit-undefined branch April 22, 2023 02:39
@lucacasonato lucacasonato mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.test() and ignore: undefined
2 participants
@nayeemrmn @bartlomieju