Skip to content

feat(cli): don't check permissions for statically analyzable dynamic imports #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

feat(cli): don't check permissions for statically analyzable dynamic imports #18713

merged 2 commits into from
Apr 26, 2023

Conversation

nayeemrmn
Copy link
Contributor

@nayeemrmn nayeemrmn commented Apr 15, 2023 •
edited
Loading

Closes #17697. Hoping to get this in a minor release, see #17697 (comment).
Closes #17658.

@bartlomieju bartlomieju requested a review from dsherret April 17, 2023 11:23
@dsherret dsherret added this to the 1.33 milestone Apr 24, 2023
dsherret
dsherret approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this makes sense given these imports show up in the output of deno info and are part of the module graph. Someone else should review this one in addition to me before we merge it though.

aapoalas
aapoalas approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also in favour.

bartlomieju
bartlomieju approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 3d8a4d3 into denoland:main Apr 26, 2023
@nayeemrmn nayeemrmn deleted the dynamic-import-static-permissions branch April 26, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Do not permission prompt for statically analyzable dynamic imports Dynamic imports require net access even when they are unused
4 participants
@nayeemrmn @dsherret @bartlomieju @aapoalas