Skip to content

fix(npm): eagerly reload package information when version from lockfile not found locally #18673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

dsherret
Copy link
Member

Closes #18624

@dsherret dsherret requested a review from bartlomieju April 12, 2023 18:51
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@dsherret dsherret requested a review from bartlomieju April 12, 2023 21:59
@dsherret dsherret merged commit 17e4782 into denoland:main Apr 12, 2023
@dsherret dsherret deleted the fix_npm_eagerly_reload_lockfile branch April 12, 2023 22:04
levex pushed a commit that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eagerly reload package information from npm registry when package version in lockfile not found in cache
2 participants