Skip to content

feat(task): introduce built-in unset command to deno task #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Apr 6, 2023

This introduces a new built-in unset command to deno task by bumping deno_task_shell to the latest version 0.11.0. Also this includes a fix on how deno task handles empty environment variables (see denoland/deno_task_shell#80 for details).

@magurotuna magurotuna force-pushed the update-deno-task-shell-to-0.11.0 branch from 181a943 to 3832869 Compare April 6, 2023 01:10
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should categorize this at least a fix(task): and outline the changes to deno task that occur because of this (perhaps it might be considered a feat even because there's a new unset command)

@magurotuna magurotuna changed the title chore(cli): bump deno_task_shell to 0.11.0 feat(task): introduce built-in unset command in deno task Apr 6, 2023
@magurotuna magurotuna changed the title feat(task): introduce built-in unset command in deno task feat(task): introduce built-in unset command to deno task Apr 6, 2023
@magurotuna
Copy link
Member Author

Updated the title and description :)

@magurotuna magurotuna merged commit 9626c48 into denoland:main Apr 6, 2023
@magurotuna magurotuna deleted the update-deno-task-shell-to-0.11.0 branch April 6, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants