Skip to content

fix(check): Use "moduleDetection": "force" #14875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2022
Merged

fix(check): Use "moduleDetection": "force" #14875

merged 3 commits into from
Jun 15, 2022

Conversation

nayeemrmn
Copy link
Contributor

dsherret
dsherret approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @nayeemrmn. I looked at the TS changes and this looks good for us to do.

@dsherret dsherret merged commit 845d475 into denoland:main Jun 15, 2022
@nayeemrmn nayeemrmn deleted the module-detection-force branch June 15, 2022 16:27
@rivy rivy mentioned this pull request Jun 22, 2022
Closed
@dsherret dsherret mentioned this pull request Jul 14, 2022
Closed
@nayeemrmn nayeemrmn mentioned this pull request Aug 6, 2022
Closed
@nayeemrmn nayeemrmn mentioned this pull request Sep 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determine correct moduleDetection compiler option (TypeScript 4.7) dynamically imported module without import / export is treated as script by tsc
2 participants
@nayeemrmn @dsherret