fix(cli/fmt_errors): don't panic on source line formatting errors #12449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Oct 15, 2021
There was a problem hiding this comment.
I wouldn't say this PR fixes #10886 but it's a good work around to stop panics.
Source lines aren't essential, most users encountering this would just like it not to panic. We should open separate issues for known and fixable cases where the source line errors like |
nayeemrmn
force-pushed
the
source-line-format-no-panic
branch
from
53269ca to
234ad3b
Compare
bartlomieju
reviewed
Oct 17, 2021
There was a problem hiding this comment.
Actually could you add an integration test that calls Deno.core.evalContext with a "wrapped" source like in #10886 (comment) ?
nayeemrmn
force-pushed
the
source-line-format-no-panic
branch
from
234ad3b to
59f8cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10886. Returns empty values in case of errors, source lines are non-essential anyway. These errors can happen e.g. when source files change at runtime. A warning is also printed to help us track when it happens in unexpected cases besides this.