revert: allow URL for permissions #11600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
reviewed
Aug 6, 2021
nayeemrmn
approved these changes
Aug 6, 2021
There was a problem hiding this comment.
The intent of #11036 was to allow file URLs for fs permission allowlists, net shouldn't have been included because that filters by host which can't sensibly be represented as URLs. I'm not sure about ever doing "full URL network permissions" down the line but either way 👍
lucacasonato
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes to "net" permissions in regards to handling URLs.
Introduced in #11578
Reverting due to @lucacasonato comment: #11578 (comment)