Skip to content

Fix bundle hashing. #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bundle hashing. #1098

wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Oct 26, 2018

Across several PRs we are experiencing AppVeyor failure. It appears to be due to the bundle not rebuilding... I believe this fixes it.

Examples of the failures we're seeing:

#1056

C:/deno/js/file_test.ts:5:20 - error TS2552: Cannot find name 'File'. Did you mean 'file'?
5   const file = new File(arg1, "name");
                     ~~~~

#1088

C:/deno/js/chmod_test.ts:18:8 - error TS2339: Property 'chmodSync' does not exist on type 'typeof import("deno")'.
18   deno.chmodSync(filename, 0o777);
          ~~~~~~~~~

@ry ry requested a review from piscisaureus October 26, 2018 14:03
@piscisaureus
Copy link
Member

Sorry but this change has nothing to do with the issues it is intended to solve.
The hasher is only active when (s)ccache is in use - it isn't on appveyor.

@ry
Copy link
Member Author

ry commented Oct 26, 2018

ok - my bad

@ry ry closed this Oct 26, 2018
@ry ry deleted the hash_h_data branch October 26, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants