Skip to content

Revert "Support CheckJS" [Merge on Approval] #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Oct 25, 2018

This reverts commit 2cfa608.

Broken on windows again -
https://ci.appveyor.com/project/deno/deno/builds/19771566

C:\deno\out\release\deno.exe C:\deno\tests\error_008_checkjs.js --reload
Expected output does not match actual.
Expected: [WILDCARD]/tests/error_008_checkjs.js�[WILDCARD] - error TS2552: Cannot find name 'consol'. Did you mean 'console'?
�[WILDCARD] consol.log("hello world!");
[WILDCARD]~~~~~~
  $asset$/lib.deno_runtime.d.ts�[WILDCARD]
[WILDCARD]declare const console: console_.Console;
[WILDCARD]~~~~~~~
[WILDCARD]'console' is declared here.
Actual:   ReferenceError: consol is not defined
    at eval (file:///C:/deno/tests/error_008_checkjs.js:2:1)
    at DenoCompiler.eval [as _globalEval] (<anonymous>)
    at DenoCompiler._gatherDependencies (deno/js/compiler.ts:220:10)
    at DenoCompiler.run (deno/js/compiler.ts:558:12)
    at denoMain (deno/js/main.ts:96:12)
    at deno_main.js:1:1

Previously: #1068, #1070, #1084

This reverts commit 2cfa608.
@ry ry requested a review from piscisaureus October 25, 2018 14:13
@ry ry changed the title Revert "Support CheckJS" Revert "Support CheckJS" [Merge on Approval] Oct 25, 2018
@ry
Copy link
Member Author

ry commented Oct 25, 2018

Closing this because master is green after #1095

@ry ry closed this Oct 25, 2018
@ry ry deleted the revert_checkjs2 branch October 25, 2018 22:33
@kitsonk
Copy link
Contributor

kitsonk commented Oct 25, 2018

Finally once it wasn't my fault! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants