Skip to content

perf(serde_v8): build with codegen-units=1 #10084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Apr 9, 2021

Lets LLVM optimize code better. Decreases ~160ns from ser_struct_v8_manual bench. Build time impact is negligible.

@ry ry requested a review from piscisaureus April 9, 2021 12:20
@AaronO
Copy link
Contributor

AaronO commented Apr 9, 2021

We previously built everything in release with codegen-units=1, #10039 removed that but #10086 reverts it, which means that this proposed optimization is actually a temporary regression that should disappear.

@AaronO
Copy link
Contributor

AaronO commented Apr 9, 2021

Also ser_struct_v8_manual isn't a benchmark we want to improve per se, it's a baseline/reference bench that compares naively/manually serializing a rust struct to v8 "by hand".

Since serde_v8 aims to be a "zero overhead" abstraction, it should be competitive or even beat manual serialization code (thanks to internalized keys, Key Cache, etc...).

@piscisaureus
Copy link
Member

I guess this is superseded by #10086.

@littledivy littledivy closed this Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants