Support Remix / React Router v7

[birkskyum]

Remix - Website - GitHub

Platform

Darwin 23.0.0 arm64 arm

Version

deno 1.37.1

Repro

Anywhere, run deno run -A npm:@remix-run/dev build, or even just deno run -A npm:@remix-run/dev

Expected

In a proper app, like in the getting started guide here, the expected state would be similar to:

➜ npx remix build
 info  building... (NODE_ENV=production)
 info  built (113ms)

Actual

➜ deno run -A npm:@remix-run/dev      
error: Uncaught Error: Not implemented: Script.prototype.runInNewContext
    at notImplemented (ext:deno_node/_utils.ts:9:9)
    at Script.runInNewContext (node:vm:22:5)
    at Object.<anonymous> (file:///Users/admin/repos/deno-kitchensink/node_modules/.deno/eval@0.1.8/node_modules/eval/eval.js:17:4)
    at Object.<anonymous> (file:///Users/admin/repos/deno-kitchensink/node_modules/.deno/eval@0.1.8/node_modules/eval/eval.js:92:4)
    at Module._compile (node:module:733:34)
    at Object.Module._extensions..js (node:module:747:10)
    at Module.load (node:module:658:32)
    at Function.Module._load (node:module:539:12)
    at Module.require (node:module:677:19)
    at require (node:module:791:16)

[bartlomieju]

#21527 will be a step towards supporting this, but most likely not enough (as the PR doesn't support any options).

[birkskyum]

Things have changed with 1.39.

Using the standard (node) template (deno run -A npm:create-remix), and running deno task dev now yields:

➜ deno task dev
Task dev remix dev --manual

 💿  remix dev

 info  building...
 info  built (374ms)
The following error is a bug in Remix; please open an issue! https://github.com/remix-run/remix/issues/new
error: Uncaught Error: errno missing
    at Object.invariant [as default] (file:///Users/admin/repos/deno-kitchensink/my-remix-app/node_modules/.deno/@remix-run+dev@2.4.0/node_modules/@remix-run/dev/dist/invariant.js:18:11)
    at ChildProcess.<anonymous> (file:///Users/admin/repos/deno-kitchensink/my-remix-app/node_modules/.deno/@remix-run+dev@2.4.0/node_modules/@remix-run/dev/dist/devServer_unstable/index.js:150:27)
    at ChildProcess.emit (ext:deno_node/_events.mjs:395:35)
    at ext:deno_node/internal/child_process.ts:238:12
    at processTicksAndRejections (ext:deno_node/_next_tick.ts:25:11)
    at runNextTicks (ext:deno_node/_next_tick.ts:71:3)
    at eventLoopTick (ext:core/01_core.js:188:21)

update: this deno template has been removed from github
Using the deno template instead: deno run -A npm:create-remix --template remix-run/remix/templates/deno, and running deno task dev:

➜ deno task dev  
Task dev npm-run-all build --parallel "dev:*"
Import map diagnostics:
  - Invalid top-level key "comment". Only "imports" and "scopes" can be present.
  - Invalid address "" for the specifier key "// `@remix-run/deno` code is already a Deno module, so just get types for it directly from `node_modules/`".

> build
> remix build

sh: remix: command not found
ERROR: "build" exited with 127.

[birkskyum]

UPDATE: This is resolved (duplicate of #21820), new errors shown in newer comments below

I tried the new vite mode of remix.

deno run -A npm:create-remix@latest --template remix-run/remix/templates/unstable-vite

.. and got this:

➜ deno task dev
Task dev remix vite:dev
failed to load config from /Users/admin/repos/deno-kitchensink/my-remix-vite/vite.config.ts
SyntaxError: The requested module 'file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/@remix-run/dev/dist/index.js' does not provide an export named 'unstable_vitePlugin' at file:///Users/admin/repos/deno-kitchensink/my-remix-vite/vite.config.ts.timestamp-1706464730208-0ec52d94af83c.mjs:2:10
    at async loadConfigFromBundledFile (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:68383:21)
    at async loadConfigFromFile (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:68240:28)
    at async resolveConfig (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:67841:28)
    at async _createServer (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:60327:20)
    at async dev (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/@remix-run/dev/dist/vite/dev.js:39:16)
    at async Object.viteDev (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/@remix-run/dev/dist/cli/commands.js:213:3)
    at async Object.run (file:///Users/admin/repos/deno-kitchensink/my-remix-vite/node_modules/.deno/@remix-run+dev@2.5.1/node_modules/@remix-run/dev/dist/cli/run.js:224:7) {
  code: "ERR_MODULE_NOT_FOUND"
}

related:

• Svelte support via Vite #16513

[arjunyel]

@birkskyum hi friend just curious if you got the Vite version of Remix working with Deno?

[birkskyum]

@arjunyel , no I tried few days ago again but didn't manage unfortunately, but I'm glad to see this ticket mentioned in here:

• Node.js compat roadmap February 2024 #22337

[birkskyum]

Another ticket relevant for remix:

• Warning: Not implemented: ChildProcess.prototype.disconnect when using Prisma #17265

[birkskyum]

Related

• fix(npm): set up node_modules/.bin/ entries for package that provide bin entrypoints #23496
• Support running scripts that contain npm run with deno task #23036

[birkskyum]

I'm now (deno 1.43.3) getting this for the standard remix (vite-based) template:

$ deno run -A npm:create-remix@latest --template remix-run/remix/templates/remix
$ deno task dev

Task dev remix vite:dev
  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
TypeError: Return value from serve handler must be a response or a promise resolving to a response
    at ext:deno_http/00_serve.ts:334:15
    at Object.runMicrotasks (ext:core/01_core.js:642:26)
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:39:10)
    at eventLoopTick (ext:core/01_core.js:165:29)
Exception in onError while handling exception TypeError: Return value from onError handler must be a response or a promise resolving to a response
    at ext:deno_http/00_serve.ts:340:17
    at Object.runMicrotasks (ext:core/01_core.js:642:26)
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:39:10)
    at eventLoopTick (ext:core/01_core.js:165:29)
Terminating Deno.serve loop due to unexpected error TypeError: Cannot read properties of undefined (reading 'status')
    at ext:deno_http/00_serve.ts:361:26
    at Object.runMicrotasks (ext:core/01_core.js:642:26)
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:39:10)
    at eventLoopTick (ext:core/01_core.js:165:29)