-
Notifications
You must be signed in to change notification settings - Fork 28
feat: egress gw #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: egress gw #1331
Conversation
I guess I'm going to have to fix the unsigned commits 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some local validation and it appears to work as expected for the most part. I want to spend a bit more time looking at the share resources and testing some things there as well but wanted to get this first batch of feedback submitted.
8c25bbd
to
3f7ea9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this as is, would like to get approvals from rest of team before merge though.
5007c72
to
4795d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking pretty good. My main concern at this point is with concurrency and race conditions, otherwise all the logic and resources seem sound.
e9a3a58
to
58f5e0d
Compare
Description
Adds egress gateway and relevant Istio resources to UDS Core.
This PR contains:
egressgateway
component in the Istio zarf package (default is not included)network.allow
parameters to support a definedremoteHost
andremoteProtocol
for workloads to send trafficNotes to reviewers
shared-egress-resources
task in ./src/test/tasks.yaml` was to try and provide some validation that the reconciliation shared egress resources was successful. It was unclear to me if this testing would be more appropriate elsewhere.Related Issue
Fixes #776
Type of change
Steps to Validate
network.allow
specification to allow egress to only a particular host. See./src/test/app-egress.yaml
for examples.Checklist before merging