rollback #6726 #7258
Open
rollback #6726 #7258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't remove the test from this PR yet because I want to witness the test failure without this change. |
Signed-off-by: Guokai Ma <[email protected]>
delock
force-pushed
the
gma/rollback_6726
branch
from
ba78b08 to
d628bb2
Compare
Signed-off-by: Guokai Ma <[email protected]>
tjruwase
approved these changes
Apr 28, 2025
|
@delock - I don't have permissions to "run tests" on this PR, do you have that button available to you? |
nv-torch-latest-v100 failed, seems this workflow has problem, latest success state is 3 days ago. |
|
Could you please include this fix in version ds 0.16.8? |
@hijkzzz - yes, as we fix the CI issues and merge this PR we can release this in a DeepSpeed release. |
loadams
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rollback #6726 which caused #7116 .