-
Notifications
You must be signed in to change notification settings - Fork 159
Pgvector hybrid #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pgvector hybrid #576
Conversation
Hey, @jlonge4! Thanks for your idea/initial implementation. I know this is a missing feature of this Document Store. |
@anakin87 thanks a lot let me know if I can do anything further! |
Hey @jlonge4, sorry for the long wait... Tomorrow I will take a proper look! |
@anakin87 no worries sir! Thank you 🙏🏼 |
Before talking about hybrid retrieval, we should introduce keyword retrieval. Then we can combine vector+keyword -> hybrid retrieval. Keyword Retrieval
TO DO (brainstorming mode 🙂)
(unsure about the name) WDYT? |
@anakin87 sounds like a great plan, bite sized pieces are better! Made a few updates based on your thoughts. |
Hey!
|
@anakin87 Definitely, I am gonna do some local testing (might take a couple days) but will get there! |
Take your time... |
Hey, I see that tests are no longer running for some reason. I would suggest to focus on Keyword Retrieval and then think about Hybrid Retrieval (maybe in another PR). Let me know if you need any help or suggestions... |
@anakin87 you are right, I believe I'll kill this PR and do as you suggested 👍🏼 |
Hi @anakin87, sorry to resurface an old issue. Are there any plans to introduce a |
Hello @kanenorman! There is no set rule. Our main goal is to provide users with hybrid retrieval capabilities, if available (using a Pipeline or not). I would say that implementing a Hybrid Retriever makes sense especially when:
|
I was hoping to implement hybrid search within the pgvector integration and use RRF for merging. This has one piece missing, and that is the user query itself (commented out in line 571. I didn't want to open an issue/enhancement and not at least provide a starting point. Let me know what you think @anakin87 @vblagoje @masci
Inspiration -> https://github.com/pgvector/pgvector-python/blob/master/examples/hybrid_search_rrf.py