Enable kwargs in SearchIndex and Embedding Retriever #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
Amnah199
commented
Nov 13, 2024
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Show resolved
Hide resolved
|
@ttmenezes would be nice to have your review as well. |
anakin87
reviewed
Nov 13, 2024
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Show resolved
Hide resolved
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Show resolved
Hide resolved
anakin87
approved these changes
Nov 15, 2024
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...earch/src/haystack_integrations/components/retrievers/azure_ai_search/embedding_retriever.py
Outdated
Show resolved
Hide resolved
Amnah199
added a commit
to ttmenezes/haystack-core-integrations
that referenced
this pull request
Nov 15, 2024
* Enable kwargs for semantic ranking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
kwargstoSearchIndexandclient.searchto enable configuration of semantic ranking if needed.DuplicatePolicyto the document store as its not needed.wait_for_index_deletionto ensure the index is deleted after each test to prevent failures caused by max no. of indexes allowed.How did you test it?
Notes for the reviewer
NA
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.