Skip to content

fix: Weaviate - skip _split_overlap meta field #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: Weaviate - skip _split_overlap meta field #1173

merged 1 commit into from
Nov 11, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

In case _split_overlap meta field is present, do not write it.

How did you test it?

CI, new test.

Checklist

@anakin87 anakin87 self-assigned this Nov 11, 2024
@anakin87 anakin87 marked this pull request as ready for review November 11, 2024 15:36
@anakin87 anakin87 requested a review from a team as a code owner November 11, 2024 15:36
@anakin87 anakin87 requested review from mpangrazzi and davidsbatista and removed request for a team November 11, 2024 15:36
@anakin87 anakin87 merged commit 1bcb9a8 into main Nov 11, 2024
8 checks passed
@anakin87 anakin87 deleted the fix-weaviate-split-overlap branch November 11, 2024 15:40
@anakin87 anakin87 mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

@anakin87 anakin87

Labels
integration:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @davidsbatista