Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

args: add entire training parameters #829

Merged
merged 1 commit into from
Jul 30, 2022
Merged

args: add entire training parameters #829

merged 1 commit into from
Jul 30, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 30, 2022

Resolves #770.

@njzjz njzjz marked this pull request as draft July 30, 2022 00:34
@njzjz njzjz linked an issue Jul 30, 2022 that may be closed by this pull request
add missing training parameters #770
Closed
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022 •
edited
Loading

Codecov Report

Merging #829 (8de3f22) into devel (f3e2b31) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel     #829      +/-   ##
==========================================
+ Coverage   35.12%   35.16%   +0.03%     
==========================================
  Files          96       96              
  Lines       16809    16817       +8     
==========================================
+ Hits         5905     5913       +8     
  Misses      10904    10904
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 49.13% <100.00%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e2b31...8de3f22. Read the comment docs.

@njzjz njzjz marked this pull request as ready for review July 30, 2022 00:43
@njzjz njzjz requested a review from Vibsteamer July 30, 2022 00:45
@wanghan-iapcm wanghan-iapcm merged commit 5a57de2 into deepmodeling:devel Jul 30, 2022
@njzjz njzjz deleted the args-training branch July 30, 2022 18:52
@njzjz njzjz mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

@Vibsteamer Vibsteamer Awaiting requested review from Vibsteamer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add missing training parameters
3 participants
@njzjz @codecov-commenter @wanghan-iapcm