autotest: rename task directory to avoid false result in a rerun #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia138ee7c31b6c41d9f41f5943affa9ebf8803c46
Codecov Report
@@ Coverage Diff @@
## devel #572 +/- ##
==========================================
+ Coverage 33.02% 33.05% +0.02%
==========================================
Files 86 86
Lines 14739 14737 -2
==========================================
+ Hits 4868 4871 +3
+ Misses 9871 9866 -5
Continue to review full report at Codecov.
|
kevinwenminion
approved these changes
Oct 14, 2021
Cloudac7
pushed a commit
to Cloudac7/dpgen
that referenced
this pull request
Dec 1, 2021
…pmodeling#572) Change-Id: Ia138ee7c31b6c41d9f41f5943affa9ebf8803c46 Co-authored-by: Zhengju Sha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we rerun
dpgen autotest make param.jsonand there are already task dirs in work directory, it only deletes and reproduces some input files like POSCAR, but leaves behind result files in last run like OUTCAR. Next when we rundpgen autotest run param.json, it will skip the task directories which already have the result files, and this may leads to a false data.Change-Id: Ia138ee7c31b6c41d9f41f5943affa9ebf8803c46