Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected behavior:
when
"labeled":true
indpgen simplify
, 02.fp will soft-link "labeled data", and the soft-linked "task dir" will also be created, for format consistency.it is expected to be
data.000
andtask.000.000000
,being respectively guaranteed by funcs
data_system_fmt
andfp_task_fmt
bug:
the typo_bug used
data_system_fmt
for the "task dir" instead offp_task_fmt
,then gives
task.000
instead oftask.000.000000
,which makes
_check_empty_iter
(who checksglob.glog("task.000.*")
) ingenerator/run.py
sentence this iter empty,then
00.train
of the next iter is always skipped.consequence:
this make the "simplify_labeled" process never starts correctly,
no iter0 model presents and randomly-picked data in iter0 are never trained,
then iter1 gives error that can't finding the graph file from iter0 when trying copying them due to the train-skip.
BTW
thought "simplify_labeled" valuable in some complex or big-data scenarios but seems not loved by users yet.
pity : (
Signed-off-by: Wanrun Jiang [email protected]