Skip to content

Many Slurm SBATCH flags are not correctly defined. #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjlow opened this issue Mar 16, 2020 · 0 comments
Closed

Many Slurm SBATCH flags are not correctly defined. #247

jjlow opened this issue Mar 16, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@jjlow
Copy link

jjlow commented Mar 16, 2020

To whom it may concern,

In the scripts ..../lib/python3.8/site-packages/dpgen/{dispatcher/Slurm.py,auto_test/lib/RemoteJob.py,remote/RemoteJob.py} many of the SBATCH flags starting with two dashes (--) are missing an equals sign (=) between the flag and the value of the flag.

For example in ..../lib/python3.8/site-packages/dpgen/remote/RemoteJob.py the blank space in column 42 of line 464 should be replaced by an equals sign (=). In other words the following line in RemoteJob.py

    ret += "#SBATCH --ntasks-per-node %d\n" % res['task_per_node']

should be

    ret += "#SBATCH --ntasks-per-node=%d\n" % res['task_per_node']

to generate a working slurm script.

Sincerely

John J. Low, Argonne National Laboratory

zezhong-zhang added a commit to zezhong-zhang/dpgen that referenced this issue Apr 1, 2020
amcadmus pushed a commit to amcadmus/dpgen that referenced this issue Apr 6, 2020
amcadmus added a commit that referenced this issue Apr 6, 2020
fix issue #247 add = to flags starting with --
@amcadmus amcadmus closed this as completed Jun 3, 2020
zezhong-zhang added a commit to zezhong-zhang/dpgen that referenced this issue Jul 1, 2020
njzjz pushed a commit to njzjz/dpgen that referenced this issue Dec 8, 2020
@njzjz njzjz added the bug Something isn't working label May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants