Skip to content

avoid retrying to download for FileNotFoundError #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 12, 2023

No description provided.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bd71277) 71.04% compared to head (a6dfbfe) 57.43%.

❗ Current head a6dfbfe differs from pull request most recent head fd298e2. Consider uploading reports for the commit fd298e2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #409       +/-   ##
===========================================
- Coverage   71.04%   57.43%   -13.62%     
===========================================
  Files          31       31               
  Lines        3568     3580       +12     
===========================================
- Hits         2535     2056      -479     
- Misses       1033     1524      +491     
Files Coverage Δ
dpdispatcher/submission.py 87.87% <0.00%> (-0.34%) ⬇️
dpdispatcher/ssh_context.py 78.49% <16.66%> (-1.51%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz merged commit 8c24fd0 into deepmodeling:master Nov 12, 2023
@njzjz njzjz deleted the do-not-catch-filenotfound branch November 12, 2023 05:32
njzjz added a commit to njzjz/dpdispatcher that referenced this pull request Nov 20, 2023
deepmodeling#409 avoids retry in loop when the file is not found in the ssh context. But it is not apply to other contexts, and the tests hang in deepmodeling/dpgen#1406 due to retry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant