Skip to content

feat(pt/tf): init-(frz)-model use pretrain script #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Jun 28, 2024

Support --use-pretrain-script for pt&tf when doing init-(frz)-model.

Summary by CodeRabbit

  • Tests
    • Enhanced and added new test cases for deep learning model initialization and evaluation.
    • Improved setup and cleanup processes for temporary files and directories in tests to ensure a cleaner test environment.

Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

Walkthrough

The recent updates involve extensive enhancements to the test_init_frz_model.py file and the introduction of a new test file, test_init_model.py. The changes in test_init_frz_model.py include importing necessary modules, updating configurations, handling temporary files, and adding robust testing for multiple DeepPot instances. The cleanup process is also implemented. The test_init_model.py file includes new tests for initializing different deep learning models and verifying their performance on input data for consistency.

Changes

Files Change Summary
source/tests/pt/test_init_frz_model.py Imported os, shutil, tempfile. Updated config, added logic for multiple cases, managed temp files, extended tests, implemented tearDown.
source/tests/pt/test_init_model.py Introduced test cases for initializing deep learning models, set up models, evaluated input data, ensured consistency.

Sequence Diagram(s)

sequenceDiagram
    participant Tester
    participant TempFileHandler
    participant DeepPotInstance
    participant ModelEvaluator

    Tester ->> TempFileHandler: Create temporary files
    Tester ->>+ DeepPotInstance: Initialize DeepPot instances
    DeepPotInstance -->> Tester: DeepPot instances created
    Tester ->> ModelEvaluator: Evaluate input data with DeepPot instances
    ModelEvaluator -->> Tester: Evaluation results
    Tester ->> DeepPotInstance: Validate assertions
    Tester ->> TempFileHandler: Clean up temporary files and directories

    Note over Tester, TempFileHandler: Temporary files and directories are managed before and after the tests.
    Note over Tester, DeepPotInstance, ModelEvaluator: Multiple DeepPot instances are created and evaluated to ensure consistency and correctness.
Loading

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dcef48c and 5bb1474.

Files selected for processing (2)
  • source/tests/pt/test_init_frz_model.py (5 hunks)
  • source/tests/pt/test_init_model.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • source/tests/pt/test_init_frz_model.py
  • source/tests/pt/test_init_model.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (c98185c) to head (5bb1474).
Report is 111 commits behind head on devel.

Files with missing lines Patch % Lines
deepmd/tf/entrypoints/train.py 6.25% 15 Missing ⚠️
deepmd/pt/entrypoints/main.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3926      +/-   ##
==========================================
- Coverage   82.89%   82.83%   -0.06%     
==========================================
  Files         520      520              
  Lines       50696    50828     +132     
  Branches     3015     3011       -4     
==========================================
+ Hits        42023    42103      +80     
- Misses       7738     7787      +49     
- Partials      935      938       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iProzd iProzd requested review from njzjz and wanghan-iapcm June 28, 2024 15:10
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we design a test case for this feature?

@iProzd iProzd linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@iProzd iProzd removed the request for review from njzjz July 2, 2024 15:09
@iProzd iProzd requested a review from njzjz July 3, 2024 01:59
@njzjz njzjz enabled auto-merge July 3, 2024 03:58
@njzjz njzjz added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@njzjz njzjz added this pull request to the merge queue Jul 3, 2024
Merged via the queue into deepmodeling:devel with commit 1c3e099 Jul 3, 2024
61 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Support `--use-pretrain-script` for pt&tf when doing init-(frz)-model.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Enhanced and added new test cases for deep learning model
initialization and evaluation.
- Improved setup and cleanup processes for temporary files and
directories in tests to ensure a cleaner test environment.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add --use-pretrain-script for init-model
3 participants