consistent energy model #3306
Merged
consistent energy model #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3306 +/- ##
==========================================
- Coverage 75.29% 75.19% -0.10%
==========================================
Files 398 399 +1
Lines 33684 33740 +56
Branches 1604 1586 -18
==========================================
+ Hits 25361 25371 +10
+ Misses 7462 7454 -8
- Partials 861 915 +54 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
njzjz
commented
Feb 20, 2024
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
| @@ -51,9 +52,19 @@ | |||
| raise RuntimeError(f"activation function {self.activation} not supported") | |||
|
|
|||
|
|
|||
| @overload | |||
| def to_numpy_array(xx: torch.Tensor) -> np.ndarray: | |||
| ... | |||
Check notice
Code scanning / CodeQL
Statement has no effect
|
|
||
| @overload | ||
| def to_numpy_array(xx: None) -> None: | ||
| ... |
Check notice
Code scanning / CodeQL
Statement has no effect
| @@ -67,9 +78,19 @@ | |||
| return xx.detach().cpu().numpy().astype(prec) | |||
|
|
|||
|
|
|||
| @overload | |||
| def to_torch_tensor(xx: np.ndarray) -> torch.Tensor: | |||
| ... | |||
Check notice
Code scanning / CodeQL
Statement has no effect
|
|
||
| @overload | ||
| def to_torch_tensor(xx: None) -> None: | ||
| ... |
Check notice
Code scanning / CodeQL
Statement has no effect
wanghan-iapcm
approved these changes
Feb 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many hacking things...