Skip to content

cc: add torch backend support for Multiple backend #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 122 commits into from
Feb 28, 2024

Conversation

CaRoLZhangxy
Copy link
Collaborator

need to test in union environment (tf and pt)
see #3119

@github-actions github-actions bot added the C++ label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: Patch coverage is 89.62264% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 75.78%. Comparing base (004ebd6) to head (da18860).
Report is 1 commits behind head on devel.

Files Patch % Lines
source/api_cc/src/DeepPotPT.cc 88.57% 13 Missing and 7 partials ⚠️
source/api_cc/src/DeepPot.cc 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3162      +/-   ##
==========================================
+ Coverage   75.64%   75.78%   +0.13%     
==========================================
  Files         411      415       +4     
  Lines       34569    34846     +277     
  Branches     1599     1614      +15     
==========================================
+ Hits        26151    26407     +256     
- Misses       7558     7571      +13     
- Partials      860      868       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz added this to the v3.0.0 milestone Jan 22, 2024
@njzjz njzjz linked an issue Jan 22, 2024 that may be closed by this pull request
@CaRoLZhangxy CaRoLZhangxy requested a review from njzjz February 28, 2024 04:10
CaRoLZhangxy and others added 6 commits February 28, 2024 13:50
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fparam and apraram are not supported yet. But I think it's okay for this PR.

@njzjz njzjz requested a review from wanghan-iapcm February 28, 2024 06:54
@njzjz njzjz added the Test CUDA Trigger test CUDA workflow label Feb 28, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 28, 2024
Co-authored-by: Han Wang <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz added the Test CUDA Trigger test CUDA workflow label Feb 28, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 28, 2024
@njzjz njzjz added this pull request to the merge queue Feb 28, 2024
Merged via the queue into deepmodeling:devel with commit d377ccb Feb 28, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Feature Request] Multiple backend C++ API
3 participants