Fix: nested + i18n customPath issue #7418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing #7389
When using nested collection combined with i18n, we encountered a bug, where instead of saving content, we would get empty commits. This did not happen when using local backend via proxy.
After inspecting exactly what happens in the backend implementation I figured out that the problem actually happens in
backend.ts
when it sets thenewPath
property as if the file was being renamed every time the customPath is set. This way the updateTree function in the API.ts goes into another mode, loops the i18n files and eventually updates the tree with existing blob IDS instead of the newly uploaded ones.Added a condition where newPath is passed on only if it differs from the currentPath - so only in case the file is actually being moved.
Test plan
Directory structure
When editing the nested entry using Github gateway it will no longer result in an empty commit instead of crating the index.sl.md file.
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)
