Skip to content

Clean up star macro #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2020
Merged

Clean up star macro #193

merged 2 commits into from
Feb 25, 2020

Conversation

invinceyble
Copy link
Contributor

One thing I extremely hate is the compiled output of the star macro, which looks extra ugly in dbt Docs 😢.

This PR gets rid of a bunch of unnecessary whitespace.

Before:

select

  "EVENT_TIME"
 ,


  "PAGE_URL"
 ,


  "GROUP"
 ,


  "CATEGORY"
 ,


  "BENCHMARK_INDEX"
 ,


  "SCORE"
 ,


  "INCLUDED_THINGS"
 from dev.model.some_table

After:

select
  "EVENT_TIME",
  "PAGE_URL",
  "GROUP",
  "CATEGORY",
  "BENCHMARK_INDEX",
  "SCORE",
  "INCLUDED_THINGS"
from dev.model.some_table

@drewbanin
Copy link
Contributor

Nice one @invinceyble - thanks for making this PR! I'm going to kick off the tests :)

@clrcrl clrcrl merged commit 2426cd5 into dbt-labs:master Feb 25, 2020
@invinceyble invinceyble deleted the clean-macro-star branch February 25, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@invinceyble @drewbanin @clrcrl