Skip to content

Improve formatting in Dockerfile #11511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KrappRamiro
Copy link

Resolves: None, its just a formatting PR

Problem

The Dockerfile:

  • Does not comply with the Docker FromAsCasing build check
  • Has inconsistent formatting for newlines in RUN instructions
  • Has too long RUN instructions
  • Has an empty continuation line in the ending of the file

Solution

This PR:

  • In the FROM instructions, replaces as with AS to comply with the Docker FromAsCasing build check
  • Aligns the lines in the multiline RUN instructions
  • Splits long RUN instructions into multiple lines
  • Removes the empty continuation line in the ending of the file

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@KrappRamiro KrappRamiro requested a review from a team as a code owner April 16, 2025 13:34
Copy link

cla-bot bot commented Apr 16, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ramiro Krapp.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Apr 16, 2025
@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants