Skip to content

Remove homebrew services from workflow #11456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

aranke
Copy link
Contributor

@aranke aranke commented Apr 3, 2025

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@aranke aranke requested a review from a team as a code owner April 3, 2025 11:01
@cla-bot cla-bot bot added the cla:yes label Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label Apr 3, 2025
@aranke aranke changed the title Remove homebrew services Remove homebrew services from workflow Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (5cd966c) to head (40595b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11456      +/-   ##
==========================================
+ Coverage   88.85%   88.91%   +0.05%     
==========================================
  Files         194      194              
  Lines       24509    24509              
==========================================
+ Hits        21778    21792      +14     
+ Misses       2731     2717      -14     
Flag Coverage Δ
integration 85.97% <ø> (+0.12%) ⬆️
unit 62.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.73% <ø> (ø)
Integration Tests 85.97% <ø> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, not sure why we were doing this in the first place.

@aranke aranke merged commit 9e6facc into main Apr 3, 2025
65 of 67 checks passed
@aranke aranke deleted the remove_homebrew_services branch April 3, 2025 13:10
@aranke
Copy link
Contributor Author

aranke commented Apr 3, 2025

hm, not sure why we were doing this in the first place.

We were using brew services to start Postgres, but now do it directly so we no longer need brew services.

I forgot to remove this line here: #11432

github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit 9e6facc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants