Skip to content

Step input is pickled only when called outside a workflow #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkline-trustle
Copy link

There may be a better way to describe this.

In python only the step output is pickled, the input is not.
Address the edge case of a `step` called outside a `workflow`.
Copy link
Contributor

@maxdml maxdml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jkline-trustle
Copy link
Author

Another case seems to be "steps used in queues run asynchronously and somewhere else, so the input must be pickled."

@kraftp
Copy link
Member

kraftp commented Feb 18, 2025

Yes, steps called asynchronously via start_workflow or queues have the same issue. I'm hesitant to merge this particular change. The fact that the inputs of steps called synchronously aren't serialized is really an implementation detail, and I'm not sure if we want to expose it in our docs. I'd rather work on a more robust solution for the problems we currently work around by passing unserializable objects to steps. I'm working on some improvements to DBOS classes and configured classes that should help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants