Skip to content

Added changes for Email Address and Credit Card Number #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

gr8nishan
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@dristysrivastava dristysrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some UTs

self.assertEqual(results[0].start, 12)
self.assertEqual(results[0].end, 38)

def test_email_with_multiple_dots(self):
Copy link
Collaborator

@shreyas-damle shreyas-damle Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTs with subdomain and multiple dots seems to be similar with different values.

@gr8nishan gr8nishan merged commit 7a60288 into daxa-ai:main Oct 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants