Skip to content

Update client version field in PDF reports and local UI app details page #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 23, 2024

Conversation

rutujaac
Copy link
Collaborator

@rutujaac rutujaac commented Aug 6, 2024

Update Pebblo Client Version Key:

  1. Pebblo Local UI:
image
  1. Show pebbloClientVersion if client version does not exist (backward compatibility):
image
  1. Reports - weasyprint report PDF:
image
  • Show nothing if client version does not exist (backward compatibility):
image
  1. Reports - xhtml2pdf report PDF:
image
  • Show nothing if client version does not exist (backward compatibility):
image

@rutujaac rutujaac marked this pull request as draft August 6, 2024 12:01
@rutujaac rutujaac force-pushed the rutuja-update-client-version-field branch from a51b160 to e44a15b Compare August 7, 2024 04:26
@rutujaac rutujaac marked this pull request as ready for review August 9, 2024 04:24
@rutujaac rutujaac force-pushed the rutuja-update-client-version-field branch from fb759fa to a080bcb Compare August 9, 2024 04:25
@shreyas-damle
Copy link
Collaborator

We need to remove client version from xhtml2pdf reports.

Screenshot 2024-08-12 at 2 08 45 PM

@rutujaac rutujaac force-pushed the rutuja-update-client-version-field branch 2 times, most recently from a12b94a to 1ccfba6 Compare August 22, 2024 04:44
@rutujaac rutujaac force-pushed the rutuja-update-client-version-field branch from 1ccfba6 to 75c72ed Compare August 23, 2024 06:48
@rutujaac rutujaac merged commit d76cf54 into daxa-ai:main Aug 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants