Skip to content

Pinned python 3.12 version for UTs #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

shreyas-damle
Copy link
Collaborator

Few UTs are failing on python 3.12.4. Ref - https://github.com/daxa-ai/pebblo/actions/runs/9609007513/job/26502752534

It is because of the compatibility with pydantic 1.10.4 version with python 3.12.4.

Executed UTs with python 3.12.3 and they are running fine.

In this PR, pinning python version to 3.12.3 untill pydantic version issue is resolved.

Local logs with python 3.12.3:

(venv-3.12.3) ➜  pebblo git:(main) ✗ make tests
pytest tests/ --durations=10
=========================================================================================== test session starts ============================================================================================
platform darwin -- Python 3.12.3, pytest-8.0.0, pluggy-1.5.0
rootdir: /Users/shreyasdamle/work/cloud_defense/shreyas-damle/pebblo
plugins: mock-3.12.0, anyio-4.4.0
collected 45 items

tests/app/config/test_config_validation.py .....                                                                                                                                                     [ 11%]
tests/app/service/test_discovery.py ...                                                                                                                                                              [ 17%]
tests/app/service/test_loader_doc.py .......                                                                                                                                                         [ 33%]
tests/app/test_daemon.py .......                                                                                                                                                                     [ 48%]
tests/app/test_prompt_api.py ....                                                                                                                                                                    [ 57%]
tests/app/test_utils.py .                                                                                                                                                                            [ 60%]
tests/entity_classifier/test_entity_classifier.py ..                                                                                                                                                 [ 64%]
tests/reports/test_report_generator.py ....                                                                                                                                                          [ 73%]
tests/reports/test_reports.py ...                                                                                                                                                                    [ 80%]
tests/topic_classifier/test_topic_classifier.py .........                                                                                                                                            [100%]

============================================================================================= warnings summary =============================================================================================
../../pebblo/venv-3.12.3/lib/python3.12/site-packages/huggingface_hub/file_download.py:1132
  /Users/shreyasdamle/work/cloud_defense/pebblo/venv-3.12.3/lib/python3.12/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================================================== slowest 10 durations ===========================================================================================
2.30s setup    tests/app/service/test_loader_doc.py::test_get_datasource_details
2.19s setup    tests/app/service/test_loader_doc.py::test_get_top_n_findings
1.92s setup    tests/app/service/test_loader_doc.py::test_update_app_details
1.89s setup    tests/app/service/test_loader_doc.py::test_get_doc_report_metadata
1.82s setup    tests/app/service/test_loader_doc.py::test_get_finding_details
1.61s setup    tests/app/service/test_loader_doc.py::test_count_files_with_findings
1.61s setup    tests/app/service/test_loader_doc.py::test_create_data_source_findings_summary
0.01s call     tests/app/test_daemon.py::test_root_endpoint

(2 durations < 0.005s hidden.  Use -vv to show these durations.)
====================================================================================== 45 passed, 1 warning in 16.04s ======================================================================================
(venv-3.12.3) ➜

@shreyas-damle shreyas-damle merged commit e7fee44 into daxa-ai:main Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants