Skip to content

Loader doc response changes for Pebblo Cloud initial work #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2024
Merged

Loader doc response changes for Pebblo Cloud initial work #297

merged 3 commits into from
Mar 29, 2024

Conversation

shreyas-damle
Copy link
Collaborator

@shreyas-damle shreyas-damle commented Mar 26, 2024 •
edited
Loading

  • Updated the response of loader/doc API
  • Handled response in case of exception
  • Updated respective unit test
  • Some ruff issues fixed caught while checking locally.

Testing:

  • Tested with/without client side changes.
  • Verified that report is getting generated as expected.
  • Verified local UI is showing individual app and all the apps.

@shreyas-damle shreyas-damle marked this pull request as ready for review March 27, 2024 17:26
@shreyas-damle shreyas-damle requested a review from Raj725 March 27, 2024 17:26
@shreyas-damle
loader doc response model added
3a5f6fb 
Response class implemented
@shreyas-damle
Ruff fixes
86687d2 
Fixed test case
Changes after testing
@shreyas-damle
LoaderDoc Model naming changed to snake_case
767d33a 
doc id added
@shreyas-damle shreyas-damle force-pushed the shreyas-loader-doc-response branch from 8092ad9 to 767d33a Compare March 28, 2024 11:32
@shreyas-damle shreyas-damle merged commit e259686 into daxa-ai:main Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raj725 Raj725 Raj725 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-damle @Raj725