Log improvements in pebblo-server. #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly review. |
|
logs: |
Comment on lines
+4
to
+5
| from io import StringIO | ||
| from tqdm import tqdm |
There was a problem hiding this comment.
I suppose, all three libraries are either present by default in python 3.9+ or already present as dependency of some other package and no need to add them to requirements.txt/pyproject.toml.
There was a problem hiding this comment.
Yes thats right.
io is part of standard library and tqdm come as a dependency in current environment. So we should be good.
pebblo/app/daemon.py
Outdated
|
|
||
| # running local server | ||
| uvicorn.run(app, host="localhost", port=8000, log_level="info") | ||
| p_bar.write("Pebblo server Stopped. BYE!") |
There was a problem hiding this comment.
I see overall 4 sections of logs - Downloading model, Topic Classifier Initialization, Entity Classifier Initialization and starting pebblo server. Is it possible to move these sections in separate function? so that code is more readable. We have some changes in this file coming soon.
There was a problem hiding this comment.
Hi @shreyas-damle
I am not able to think of a way how can we move scattered logging into a common function, they are all stdouts. We are steering progress bar and screen message one by one, hence we have this many logs.
But I think we can have a common function to update progress bar and stdout text messages with both to be passed as an argument. This way we can make the code a bit readable.
What do you think, please suggest.
There was a problem hiding this comment.
Hi @shreyas-damle
made changes in the daemon file as per our recent discussion.
|
@rahul-trip Overall logs are better now, API info logs missing though. |
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul_pebblo_logs
branch
from
c902012 to
64370d5
Compare
|
Latest output: |
Screencast.from.09-02-24.12.08.02.AM.IST.webmAlso: We need to suppress logs from router initialisation because it is printing torch package's warnings (See below) as it is importing TopicClassifier class which is importing something from presedio and so on.. If we dont suppress stdout and stderr of router initialisation, we get following logs: |
Signed-off-by: Rahul Tripathi <[email protected]>
|
Hi @shreyas-damle We can simply send the logs to uvicorn logging instance as it has a context of its own. 🙌 cc: @srics |
|
Another option to print our logs would be to create another context with stdout and stderr restored whenever we need to print the logs. |
Rahul quick fix
Signed-off-by: Rahul Tripathi <[email protected]>
|
Latest video.: Screencast.from.13-02-24.01.34.45.PM.IST.webm |
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul_pebblo_logs
branch
from
5f7a0c8 to
e918c1a
Compare
shreyas-damle
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.