Skip to content

Add the option "ref", specifying either a commit or a branch #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

mstorsjo
Copy link
Contributor

This fixes #242.

Copy link
Owner

@dawidd6 dawidd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👍 Thanks

@dawidd6 dawidd6 merged commit 4c1e823 into dawidd6:master May 30, 2025
7 of 20 checks passed
@mstorsjo mstorsjo deleted the ref branch May 30, 2025 19:41
@mstorsjo
Copy link
Contributor Author

Thanks! Would you mind adding a new tag, so one can use the new option without needing to reference a raw commit id?

@dawidd6
Copy link
Owner

dawidd6 commented May 31, 2025

Sure. v10 released 😄.

mstorsjo added a commit to mstorsjo/llvm-mingw that referenced this pull request Jun 3, 2025
This allows specifying either a commit or a branch in the same
field, allowing simplifying both the workflow inputs, and
the expressions for passing commit/branch to both
dawidd6/action-download-artifact and actions/checkout.

This new option is available since
dawidd6/action-download-artifact#329.
@mstorsjo
Copy link
Contributor Author

mstorsjo commented Jun 3, 2025

Sure. v10 released 😄.

Thanks!

For reference, this new option allows significantly simplifying some workflows of mine, where manually triggered workflows can run either with a commit or a branch (together with passing the same to https://github.com/actions/checkout), and the logic for dealing with this has required a lot of extra conditionals all over the place; see mstorsjo/llvm-mingw@9633e75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying commit and branch in the same field
2 participants