-
Notifications
You must be signed in to change notification settings - Fork 134
Bench improvements with config files #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lify loading code
…imilarity function of the dataset
…chYAML for specifying the yaml files as program arguments
…g.getDefaultConfig. Clean comments up
# Conflicts: # rat-excludes.txt
tlwillke
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few ease-of-use tools in jvector-examples. These tools are mainly related to codeless benchmarking through the use of config files for setting hyperparameters.
jvector-examples/yaml-configs/datasets.yml
. The datasets indatasets.yml
can be commented to run a subset, for example. Additionally, Bench now allows to specify a list of overquery values for each topK value.BenchYAML
that allows to read config files with JVector hyperparameters in YAML format. For details on the format of these config files, see below.HelloVectorWorld
with a single, clean, and simple example using ada002-100k. This example does not do a grid search over the hyperparameters, but it does try a few overquery values for topK=10 and topK=100. The corresponding config file is injvector-examples/yaml-configs/ada002-100k.yml
.Here's an example YAML file showing what and how we can specify hyperparameters: