Lower startup memory usage by loading huge dictionaries from JSON files #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mparent61
changed the title
mparent61
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors initialization to load "ratio" and "gender_names" dictionary data from JSON instead of using giant static Python dictionaries.
When we originally added
probablepeopleto our Flask application, it increased our app's peak memory footprint by 600MB during startup, causing OOM errors in our deployment infrastructure. Following a suggestion from a related issue, and also taking inspiration from another fork, this eliminates the 600MB spike by loading the dictionary data from a JSON file.I've taken a simple approach that attempts to minimize code changes, basically converting the two dictionary
.pyfiles to.jsonand loading at import-time. But certainly open to suggestions, as there are many ways to skin this cat.