Skip to content

DLT runtimes display fix and issue #182 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 8, 2022
Merged

Conversation

souvik-databricks
Copy link
Contributor

This pull request contains the bug fix for the display function for DLT runtimes and the change for github issue #182

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes needed, please see the inline comments.

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our conversation on slack, I think we should be testing for the presence of the DLT library by something like:

def __has_dlt():
  try:
    import dlt
    return true
  except ModuleNotFoundError:
    return false

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #186 (095fd97) into master (30e71eb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   84.62%   84.63%   +0.01%     
==========================================
  Files           8        8              
  Lines         982      983       +1     
==========================================
+ Hits          831      832       +1     
  Misses        151      151              
Impacted Files Coverage Δ
tempo/utils.py 50.00% <0.00%> (ø)
tempo/tsdf.py 71.31% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e71eb...095fd97. Read the comment docs.

@souvik-databricks souvik-databricks linked an issue Apr 8, 2022 that may be closed by this pull request
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tnixon tnixon merged commit 7f56692 into master Apr 8, 2022
@tnixon tnixon deleted the bugfix/supportForDLTRuntimes branch April 8, 2022 19:13
@souvik-databricks souvik-databricks linked an issue Apr 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Tempo in DLT workflows Update Name of Column in tempo describe
3 participants