-
Notifications
You must be signed in to change notification settings - Fork 56
DLT runtimes display fix and issue #182 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small changes needed, please see the inline comments.
…d the python code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our conversation on slack, I think we should be testing for the presence of the DLT library by something like:
def __has_dlt():
try:
import dlt
return true
except ModuleNotFoundError:
return false
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 84.62% 84.63% +0.01%
==========================================
Files 8 8
Lines 982 983 +1
==========================================
+ Hits 831 832 +1
Misses 151 151
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This pull request contains the bug fix for the display function for DLT runtimes and the change for github issue #182