-
Notifications
You must be signed in to change notification settings - Fork 22
Add dev tools #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add dev tools #17
Conversation
Thanks @JordiNeil ! Would you mind adding unit tests for some of the tools you introduced? You can see the tests for the Unity Catalog MCP server in https://github.com/databrickslabs/mcp/tree/master/servers/unity_catalog/tests as an example - cc also @jai-behl @annzhang-db to take a look |
…ckslabs#16) This reverts commit de9bef9. Signed-off-by: Shingo OKAWA <[email protected]>
🍱 restructure project to make it `databricks.labs` compliant
Signed-off-by: Shingo OKAWA <[email protected]>
…ADME links (databrickslabs#23) Signed-off-by: Sid Murching <[email protected]>
Do you want to keep a single pyproject.toml for the entire repo? Or do you want to separate each mcp server? |
cc @renardeinside to comment here - initially we had multiple pyproject.toml, but @renardeinside helped update to a single one to match the standard of other Databricks Labs projects - I imagine we'd want to stick with that pattern here |
Dear team, To manage separated dependencies please use dependency groups:
And not separate |
Same on the topic of separate readme.mds -> please keep everything inside one README.md in the repository root. |
As for the PR in general:
When PR is ready please tag @smurching and me for review. I would like to highlight that It's a great piece of work, please don't consider my comments as nitpicks - just helping to structure and unify labs approaches across projects. |
Related Issues/PRs
These changes are related to issue #5 regarding adding dev tools
I tried to follow current structure for UC mcp
What changes are proposed in this pull request?
Add:
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Added new tools for jobs, sql query and test connection.
Added docker
How should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes