-
Notifications
You must be signed in to change notification settings - Fork 56
Add Profiler Installer/Uninstaller for Windows #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goodwillpunning
wants to merge
11
commits into
main
Choose a base branch
from
feature/add_profiler_installer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 15/16 passed, 1 failed, 1 skipped, 1m24s total ❌ test_gets_maven_version: AttributeError: 'NoneType' object has no attribute 'split' (1m0.269s)
Running from acceptance #705 |
Closed
Patch for integration test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an installer and uninstaller for the data warehouse profiler.
What does this PR do?
This PR adds an installer/uninstaller for the 3 major operating systems (macOS, Windows, and Linux). This PR includes relevant documentation for installing/uninstalling the profiler.
Relevant implementation details
One of the goals of the profiler is to make it easy to install on a local machine without needing a Databricks workspace. Secondly, gathering enough usage data and metrics is critical in calculating an accurate Total Cost of Ownership (TCO). This PR leverages the built-in scheduling components of the host operating system to schedule usage collection so that enough usage information is used in providing a TCO estimate.
Caveats/things to watch out for when reviewing:
Linked issues
Resolves #1470.
Functionality
databricks labs remorph ...
Tests