-
Notifications
You must be signed in to change notification settings - Fork 426
Support serverless workspaces in databricks_mws_workspaces
#4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serverless workspaces in databricks_mws_workspaces
#4670
Conversation
@@ -577,7 +583,7 @@ func ResourceMwsWorkspaces() common.Resource { | |||
var workspace Workspace | |||
workspacesAPI := NewWorkspacesAPI(ctx, c) | |||
common.DataToStructPointer(d, workspaceSchema, &workspace) | |||
if err := requireFields(c.IsAws(), d, "aws_region", "credentials_id", "storage_configuration_id"); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have two cases - when compute_mode is serverless, then use this new condition, and when isn't, then use the old condition?
NEXT_CHANGELOG.md
Outdated
@@ -5,7 +5,11 @@ | |||
### New Features and Improvements | |||
|
|||
* Add support for `power_bi_task` in jobs ([#4647](https://github.com/databricks/terraform-provider-databricks/pull/4647)) | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to review merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah new laptop/editor, need to setup autosave.
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
## Release v1.75.0 ### New Features and Improvements * Add support for `power_bi_task` in jobs ([#4647](#4647)) * Add support for `dashboard_task` in jobs ([#4646](#4646)) * Add `compute_mode` to `databricks_mws_workspaces` to support creating serverless workspaces ([#4670](#4670)). * Make `spark_version` optional in the context of jobs such that a cluster policy can provide a default value ([#4643](#4643)) ### Documentation * Document `performance_target` in `databricks_job` ([#4651](#4651)) * Add more examples for `databricks_model_serving` ([#4658](#4658)) * Document `on_streaming_backlog_exceeded` in email/webhook notifications in `databricks_job` ([#4660](#4660)) * Refresh `spark_python_task` option in `databricks_job` ([#4666](#4666)) ### Exporter * Emit files installed with `%pip install` in Python notebooks ([#4664](#4664)) * Correctly handle account-level identities when generating the code ([#4650](#4650)) * Add export of dashboard tasks in `datarbicks_job` ([#4665](#4665)) * Add export of PowerBI tasks in `datarbicks_job` ([#4668](#4668)) * Add `Ignore` implementation for `databricks_grants` to fix issue with wrongly generated dependencies ([#4650](#4650)) * Improve handling of `owner` for UC resources ([#4669](#4669))
Changes
A new field
compute_mode
has been added todatabricks_mws_workspaces
. This can be set toSERVERLESS
to indicate that a workspace should be serverless. Serverless workspaces are documented at https://docs.databricks.com/aws/en/admin/workspace/serverless-workspaces. These workspaces need neithercredentials_id
orstorage_configuration_id
, so the setup should be much easier.Tests
Added an integration test for creating serverless workspaces in AWS.
Todos