[Fix] Skip Read after Create in databricks_secret_acl to avoid errors
#4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very common situation when the Secret Scope ACL assignment fails when it happens right after a principal assignment to a workspace. Technically we don't need to perform `Read` after resource creation as no additional data is returned by GET Secret Scope ACL API. Hopefully it will resolve #2423
nkvuong
approved these changes
Mar 4, 2025
tanmay-db
approved these changes
Mar 4, 2025
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
approved these changes
Mar 11, 2025
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Mar 12, 2025
## Release v1.70.0 ### Bug Fixes * Fix creation of `databricks_storage_credential` and `databricks_credential` resources on GCP with isolation mode ([#4563](#4563)) * Handle auto-enabled errors with `databricks_system_schema` [#4547](#4547) * Skip Read after Create in `databricks_secret_acl` to avoid errors([#4548](#4548)). ### Documentation * Document `amazon_bedrock_config.instance_profile_arn` in `databricks_model_serving` ([#4549](#4549)) * Document management of permissions of `databricks_budget_policy` resource ([#4561](#4561)) * Document `budget_policy_id` in `databricks_app` resource and data sources ([#4557](#4557)) * Add a note on how `databricks_grants` work with `MANAGE` permission [#4546](#4546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It's very common situation when the Secret Scope ACL assignment fails when it happens right after a principal assignment to a workspace. Technically we don't need to perform
Readafter resource creation as no additional data is returned by GET Secret Scope ACL API.Hopefully it will resolve #2423
Tests
make testrun locallydocs/folderinternal/acceptance