Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Bump Go SDK to 0.59.0 #4544

Merged
merged 3 commits into from
Mar 4, 2025
Merged

[Internal] Bump Go SDK to 0.59.0 #4544

merged 3 commits into from
Mar 4, 2025

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Mar 3, 2025 •
edited
Loading

Changes

This pull request includes the following updates:

  1. Updated the Go SDK to version 0.59.0.
  2. Generated code in line with the latest OpenAPI schema.
  3. Implemented a fix to avoid any breaking changes in the Share resource.
  4. Temporarily bypassing some GCP workspace tests until the environmental issues are resolved.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@rauchy rauchy requested review from a team as code owners March 3, 2025 14:44
@rauchy rauchy requested review from tanmay-db and removed request for a team March 3, 2025 14:44
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 14:44 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 14:46 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 15:57 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 15:59 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 16:04 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 3, 2025 16:05 — with GitHub Actions Inactive
@alexott
Copy link
Contributor

alexott commented Mar 3, 2025

@rauchy why not to do Go SDK bump as a separate PR? Especially because current PR is without changelog

@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 3, 2025 18:42 — with GitHub Actions Inactive
@tanmay-db
Copy link
Contributor

Hi @alexott, Go SDK bump is a breaking change so those fixes would have to be together in a PR

@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 3, 2025 18:43 — with GitHub Actions Inactive
@tanmay-db tanmay-db mentioned this pull request Mar 3, 2025
Closed
5 tasks
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 08:47 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 08:48 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 10:11 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 10:12 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 12:45 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 12:45 — with GitHub Actions Inactive
@rauchy rauchy changed the title [Internal] Match sharing/catalog permission signatures [Internal] Bump Go SDK to 0.59.0 Mar 4, 2025
@rauchy rauchy requested a review from renaudhartert-db March 4, 2025 12:47
@renaudhartert-db renaudhartert-db added this pull request to the merge queue Mar 4, 2025
@renaudhartert-db renaudhartert-db removed this pull request from the merge queue due to a manual request Mar 4, 2025
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 13:51 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is March 4, 2025 13:51 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4544
  • Commit SHA: def45ca5446720d9fb60f34e1998fb1c0862f01f

Checks will be approved automatically on success.

@rauchy rauchy enabled auto-merge March 4, 2025 13:52
@rauchy rauchy added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 0842543 Mar 4, 2025
12 of 13 checks passed
@rauchy rauchy deleted the bump-go-sdk branch March 4, 2025 13:59
deco-sdk-tagging bot added a commit that referenced this pull request Mar 4, 2025
@deco-sdk-tagging
[Release] Release v1.69.0
f50e02d 
## Release v1.69.0

### Documentation

* Added budget_policy resource and data source documentation

### Internal Changes

 * Bump Go SDK version to 0.59.0 ([#4544](#4544))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

@renaudhartert-db renaudhartert-db renaudhartert-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rauchy @alexott @tanmay-db @renaudhartert-db