[Fix] Only allow authorized_paths to be updated in the options field of databricks_catalog
#4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `databricks_catalog`
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
approved these changes
Feb 21, 2025
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
added a commit
that referenced
this pull request
Feb 26, 2025
### New Features and Improvements * Add support for cluster logs delivery to UC Volumes ([#4492](#4492)). * Expose more attributes for `databricks_connection` resource ([#4502](#4502)). * add `databricks_dashboards` data source ([#4521](#4521)). ### Bug Fixes * Delete `databricks_sql_endpoint` that failed to start ([#4520](#4520)). * Fix filling of missing attributes in `databricks_quality_monitor` ([#4519](#4519)). * Mark `default_catalog_name` attribute in `databricks_metastore_assignment` as deprecated ([#4522](#4522)). * Only allow `authorized_paths` to be updated in the `options` field of `databricks_catalog` ([#4517](#4517)). * Populate `partitions` when reading `databricks_sql_table` ([#4486](#4486)). * Remove configuration drift when configuring `databricks_connection` to built-in Hive Metastore ([#4505](#4505)). ### Documentation * Improve documentation for databricks_cluster and databricks_clusters ([#4506](#4506)). * Small fix to docs for data source `databricks_cluster` ([#4510](#4510)). * mark `databricks_volume` and `databricks_credential` as GA ([#4524](#4524)). ### Internal Changes * Upgrade `staticcheck` to compatible with Go 1.24 ([#4507](#4507)). * Use InputGitAuthor when tagging a commit ([#4501](#4501)). * fix `TestUcAccDataSourceShares` flakiness ([#4526](#4526)). * switch `TestMwsAccWorkspacesTokenUpdate` to BYOVPC ([#4525](#4525)). ### Dependency Updates * Bump github.com/hashicorp/terraform-plugin-framework from 1.14.0 to 1.14.1 ([#4515](#4515)). * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.16.0 to 0.17.0 ([#4511](#4511)). * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.36.0 to 2.36.1 ([#4512](#4512)). * Bump to 1.24.0 ([#4508](#4508)). ### Exporter * Explicitly abort execution via `panic` if list of users can't be fetched ([#4500](#4500)). * Fix matching on `workspace_path` and refactoring ([#4504](#4504)).
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Feb 26, 2025
## Release v1.67.0 ### New Features and Improvements * Add support for cluster logs delivery to UC Volumes ([#4492](#4492)). * Expose more attributes for `databricks_connection` resource ([#4502](#4502)). * Add `databricks_dashboards` resource ([#4521](#4521)) ### Bug Fixes * Populate `partitions` when reading `databricks_sql_table` ([#4486](#4486)). * Fix configuration drift when configuring `databricks_connection` to builtin Hive Metastore ([#4505](#4505)). * Only allow `authorized_paths` to be updated in the `options` field of `databricks_catalog` ([#4517](#4517)). * Mark `default_catalog_name` attribute in `databricks_metastore_assignment` as deprecated ([#4522](#4522)) * Delete `databricks_sql_endpoint` that failed to start ([#4520](#4520)) * Fix filling of missing attributes in `databricks_quality_monitor` ([#4519](#4519)). ### Documentation * Update `databricks_cluster` and `databricks_clusters` data source documentation ([#4506](#4506)). ### Exporter * Explicitly abort execution via `panic` if list of users can't be fetched ([#4500](#4500)). * Fix matching on `workspace_path` and refactoring ([#4504](#4504)). ### Internal Changes * Bump golang version to 1.24.0 ([#4508](#4508)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There was a misunderstanding with the Unity Catalog API in connection with #4476. Apparently, only
authorized_pathsis eligible for update in the UC Catalog API. Otherwise, any other changes tooptionsmust trigger resource recreation.This PR customizes the logic of
databricks_catalogto do this. To be specific:CustomizeDiffmarks theoptionsfield asForceNewif there is a key other thanauthorized_pathswhich was updated.Updatecommand removes any options that aren'tauthorized_paths. This might be the case in the future if other options are added for HMS catalogs that can be set at create time but not updated.Createcommand removes any options from theUpdateCatalogRPC.Tests
Added two integration tests to verify the behavior of
databricks_catalogupdate.TestUcAccCatalogUpdateto verify that adding options with a key other thanauthorized_pathsto a catalog defined without any options causes the catalog to be recreated.TestUcAccCatalogHmsConnectionUpdatewhich tests the lifecycle of HMS catalogs, including updating theauthorized_pathsoption, enforcing that the catalog resource is never deleted during the lifecycle of the test.